Skip to content

Conversation

@vbabenkoru
Copy link
Contributor

The error message may be null so we pass the exception itself instead
Fixes #126

The error message may be null so we pass the exception itself instead
@vbabenkoru vbabenkoru requested a review from davidtruong August 5, 2019 17:33
@codecov
Copy link

codecov bot commented Aug 5, 2019

Codecov Report

Merging #127 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
- Coverage    73.1%   73.02%   -0.08%     
==========================================
  Files          34       34              
  Lines        1948     1950       +2     
  Branches      213      213              
==========================================
  Hits         1424     1424              
- Misses        385      387       +2     
  Partials      139      139
Impacted Files Coverage Δ
...ain/java/com/iterable/iterableapi/IterableApi.java 65.09% <0%> (ø) ⬆️
.../iterable/iterableapi/IterableDeeplinkManager.java 76.66% <0%> (-1.3%) ⬇️
...java/com/iterable/iterableapi/IterableRequest.java 85.71% <0%> (-0.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f92a4b...c270787. Read the comment docs.

Copy link
Contributor

@davidtruong davidtruong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbabenkoru vbabenkoru merged commit 9a5f535 into master Aug 6, 2019
@vbabenkoru vbabenkoru deleted the bugfix/MOB-580-fix-getAdvertisingId-npe branch August 6, 2019 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash when retrieving the advertisement id

3 participants